Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 방명록 수정 #43

Merged
merged 3 commits into from
Aug 19, 2023
Merged

fix: 방명록 수정 #43

merged 3 commits into from
Aug 19, 2023

Conversation

asdf99245
Copy link
Collaborator

@asdf99245 asdf99245 commented Aug 19, 2023 •
edited
Loading

👀 What is this PR?

방명록 관련 이슈 수정

📝 Changes

  • 방명록 날짜가 ISO string그대로 표시되고 있었음 -> Locale string형식으로 수정
  • 방명록 배너에 긴 텍스트가 있을 시 텍스트가 배너를 넘어가는 현상 수정 -> ellipsis 처리
  • 방명록 작성 페이지에서 긴 텍스트가 있을 시 박스를 넘어가는 현상 수정 -> 이건 일단 overflow scroll 처리

📌 Related issue(s)

📷 Attachment(optional)

image image

@github-actions github-actions bot requested a review from bsy1141 August 19, 2023 02:51
@asdf99245 asdf99245 changed the title fix: 방명록 날짜 iso string -> locale string으로 수정 fix: 방명록 수정 Aug 19, 2023
@asdf99245 asdf99245 merged commit d36668b into main Aug 19, 2023
@asdf99245 asdf99245 deleted the fix/guest-book-date branch August 19, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsy1141 bsy1141 Awaiting requested review from bsy1141

Assignees

@asdf99245 asdf99245

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asdf99245