refactor: move request logger middleware to express level

NexusMutual · Jan 7, 2025 · 5b20a47 · 5b20a47
1 parent 7b4a406
commit 5b20a47
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 32 deletions.
diff --git a/src/index.js b/src/index.js
@@ -43,6 +43,12 @@ const main = async () => {
     next();
   });
 
+  // log incoming requests
+  app.use((req, res, next) => {
+    console.info(`${req.method} ${req.originalUrl}`);
+    next();
+  });
+
   // initiate routes
   app.use('/v2', capacityRouter);
   app.use('/v2', quoteRouter);

diff --git a/src/routes/capacity.js b/src/routes/capacity.js
@@ -3,7 +3,6 @@ const { inspect } = require('node:util');
 const { ethers, BigNumber } = require('ethers');
 const express = require('express');
 
-const { requestLogger } = require('./middleware');
 const {
   getAllProductCapacities,
   getProductCapacity,
@@ -13,10 +12,8 @@ const {
 const { SECONDS_PER_DAY } = require('../lib/constants');
 const { asyncRoute } = require('../lib/helpers');
 
-const { formatUnits } = ethers.utils;
-
 const router = express.Router();
-router.use(requestLogger);
+const { formatUnits } = ethers.utils;
 
 const formatCapacityResult = capacity => ({
   productId: capacity.productId,

diff --git a/src/routes/middleware.js b/src/routes/middleware.js
diff --git a/src/routes/pricing.js b/src/routes/pricing.js
@@ -2,12 +2,10 @@ const { inspect } = require('node:util');
 
 const express = require('express');
 
-const { requestLogger } = require('./middleware');
 const { asyncRoute } = require('../lib/helpers');
 const { pricingEngine } = require('../lib/pricingEngine');
 
 const router = express.Router();
-router.use(requestLogger);
 
 const formatPricingResult = pricing => ({
   productId: pricing.productId,

diff --git a/src/routes/quote.js b/src/routes/quote.js
@@ -3,16 +3,13 @@ const { inspect } = require('node:util');
 const { BigNumber, ethers } = require('ethers');
 const express = require('express');
 
-const { requestLogger } = require('./middleware');
 const { TARGET_PRICE_DENOMINATOR } = require('../lib/constants');
 const { asyncRoute } = require('../lib/helpers');
 const { quoteEngine } = require('../lib/quoteEngine');
 const { selectAsset } = require('../store/selectors');
 
-const { Zero } = ethers.constants;
-
 const router = express.Router();
-router.use(requestLogger);
+const { Zero } = ethers.constants;
 
 /**
  * @openapi