Feature: Usage endpoints #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shark0der
reviewed
Aug 22, 2023
shark0der
reviewed
Aug 22, 2023
shark0der
reviewed
Aug 22, 2023
| const newProductIds = [...new Set([...previousProductIds, productId])]; | ||
| const poolProductIds = { ...state.poolProductIds, [poolId]: newProductIds }; | ||
|
|
||
| return { ...state, poolProducts, productPoolIds, poolProductIds }; |
There was a problem hiding this comment.
As discussed: remove productPoolIds and poolProductIds to remove redundancy and create selectors instead
MilGard91
force-pushed
the
feature/pool-endpoints
branch
from
1c4a1d7 to
67bfe36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Issue: #38
Changes proposed in this pull request
Add usage routes and usageEngine that will return used capacity of a pool by product