Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assetId inconsistency in /capacity and /quote (breaking change - fix in v3?) #88

Open
rackstar opened this issue May 31, 2024 · 0 comments
Open

assetId inconsistency in /capacity and /quote (breaking change - fix in v3?) #88

rackstar opened this issue May 31, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@rackstar
Copy link
Contributor

rackstar commented May 31, 2024 •
edited
Loading

Overview

assetId should be in number format because Pool.getAsset(uint assetId)

Fix assetId inconsistency in v3? (BREAKING CHANGE)

/capacity (assetId: Integer)

{"assetId":255,"amount":"195995240000000000000000"}

/quote (assetId: IntegerString) - fix to be integer

{"assetId":"255","amount":"81071620000000000000000"}
@rackstar rackstar added the enhancement New feature or request label May 31, 2024
@roxdanila roxdanila moved this from ⚖ Backlog to Coming Next in Engineering Tracker 💻 Jun 1, 2024
@roxdanila roxdanila moved this from Coming Next to ⚖ Backlog in Engineering Tracker 💻 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Engineering Tracker 💻
Status: ⚖ Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rackstar