Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add log levels #157

Merged
merged 8 commits into from
Jan 7, 2025
Merged

chore: add log levels #157

merged 8 commits into from
Jan 7, 2025

Conversation

rackstar
Copy link
Contributor

@rackstar rackstar commented Jan 6, 2025

Description

  • add @nexusmutual/utils as dependency (which contains log-level lib)
  • differentiate logs to different console methods to utilise log levels

cover-router logging:

  • for each end-point we log the request params as well as the API response (except for /capacity as its too verbose)
  • I went through all the consoles and aside from logging the responses the only objects we log that I can see is poolsData when we encounter an error (these is now under debug log)
  • as far as I can tell, all the other consoles only log non-objects aside from these

Testing

manually tested locally

Checklist

  • Performed a self-review of my own code
  • Made corresponding changes to the documentation

@rackstar rackstar added the chore label Jan 6, 2025
@rackstar rackstar self-assigned this Jan 6, 2025
@rackstar rackstar marked this pull request as draft January 6, 2025 11:31
@rackstar
Copy link
Contributor Author

rackstar commented Jan 6, 2025

marking a draft until @nexusmutual/utils 0.0.1 has been publish

EDIT: marked as ready

@rackstar rackstar force-pushed the chore/add-log-levels branch from 71b19fa to f28d60f Compare January 7, 2025 12:00
@rackstar rackstar force-pushed the chore/add-log-levels branch from f28d60f to 329dc71 Compare January 7, 2025 12:02
@rackstar rackstar changed the title DRAFT: chore: add log levels chore: add log levels Jan 7, 2025
@rackstar rackstar marked this pull request as ready for review January 7, 2025 12:02
src/config.js Outdated Show resolved Hide resolved
@shark0der shark0der merged commit 9407e6c into dev Jan 7, 2025
5 checks passed
@shark0der shark0der deleted the chore/add-log-levels branch January 7, 2025 12:36
@rackstar rackstar mentioned this pull request Jan 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants