Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reduce logging #159

Merged
merged 4 commits into from
Jan 8, 2025
Merged

chore: reduce logging #159

merged 4 commits into from
Jan 8, 2025

Conversation

rackstar
Copy link
Contributor

@rackstar rackstar commented Jan 7, 2025 •
edited
Loading

Description

  • set /capacity/pools/:poolId response logging to debug as its too verbose
  • add request logging middleware to express level
GET /v2/quote
query: {
  productId: '240',
  amount: '1000000000000000',
  period: '30',
  coverAsset: '0'
}

Testing

tested locally

Checklist

  • Performed a self-review of my own code
  • Made corresponding changes to the documentation

@rackstar rackstar added the chore label Jan 7, 2025
@rackstar rackstar requested a review from shark0der January 7, 2025 15:38
@rackstar rackstar self-assigned this Jan 7, 2025
shark0der
shark0der reviewed Jan 7, 2025
View reviewed changes
src/routes/capacity.js Outdated Show resolved Hide resolved
shark0der
shark0der reviewed Jan 7, 2025
View reviewed changes
src/routes/middleware.js Outdated Show resolved Hide resolved
shark0der
shark0der requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@shark0der shark0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request logging

@rackstar rackstar force-pushed the chore/reduce-logging branch from a139d24 to d847b8d Compare January 7, 2025 16:39
@rackstar rackstar force-pushed the chore/reduce-logging branch from d847b8d to 5b20a47 Compare January 7, 2025 16:40
@shark0der shark0der merged commit c2d2818 into dev Jan 8, 2025
5 checks passed
@shark0der shark0der deleted the chore/reduce-logging branch January 8, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shark0der shark0der shark0der approved these changes

Assignees

@rackstar rackstar

Labels
chore
Projects
Engineering Tracker 💻
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rackstar @shark0der