coeurl issues

[yuyichao]

My account request at nheko.im was rejected so I cannot report an issue there or submit a pull request so these are the issues...

1. There's some copy-n-paste issues at https://nheko.im/nheko-reborn/coeurl/-/blob/22f58922da16c3b94d293d98a07cb7caa7a019e8/CMakeLists.txt#L22-25

   The messages are all the same and there are two USE_BUNDLED_SPDLOGs.

2. The install at https://nheko.im/nheko-reborn/coeurl/-/blob/22f58922da16c3b94d293d98a07cb7caa7a019e8/CMakeLists.txt#L137 has the wrong namespace.

   It should be coeurl:: (to be consistent with line 121) or ${PROJECT_NAME}::.

3. There is no pkg-config files generated but this project uses those:

   mtxclient/CMakeLists.txt

   Line 173 in a4f4c79

   find_package(PkgConfig REQUIRED)

   Setting a dummy coeurl_DIR seem to work around that though the installed cmake config isn't usable due to the previous issue.

[deepbluev7]

Sorry, I rejected the account request, because we get a lot of spam from gmail addresses and it is hard to distinguish them, if people don't ask about an account in one of our rooms first. We should probably add that to the registration page.

Now about your bugs:

1 and 2 should be easy to fix, I will do that.

3 is a bit more difficult. We don't intend to keep the CMake build, since it is quite convoluted. Instead we will transition mtxclient to meson in the future. For that reason the intended way to build coeurl is to use meson, which should generate the appropriate pkgconfig file. I should make that clearer in the documentation.

[yuyichao]

Using meson is fine, as long as the cmake build, when present, is also correct (i.e. issue 1 and 2). May be better to have a different flag than coeurl_DIR to control what to look for (or better, do that automatically) but if the cmake version is temporary the current one is fine.

I switched my build script to use meson for coeurl instead and it indeed generates the right pkg-config files.

[deepbluev7]

The cmake build is currently needed to be able to use it via the bundled flags in Nheko. I.e. if you pass -DUSE_BUNDLED_COEURL=ON. I haven't found a good way to do that with meson builds, which is why there are 2 build files atm.

[yuyichao]

I see. I guess that's also why the export version of the cmake config files are correct whereas the installed ones are wrong...

[deepbluev7]

Yes, we never used the installed ones