Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text selection in message window #619

Closed
yuyichao opened this issue Jun 22, 2021 · 6 comments
Closed

Allow text selection in message window #619

yuyichao opened this issue Jun 22, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@yuyichao
Copy link

Is your feature request related to a problem? Please describe.
AFAICT, currently, it's only possible to copy the whole message and not part of it. It's quite inconvenient in many cases IMO. (and #618 makes this much worse....) This also makes #617 worse since I couldn't even select only the link and copy it to the browser...

Describe the solution you'd like
As the title says, allow selecting the text in the message window and enable standard copying hotkey

Describe alternatives you've considered
Copying to a different window and edit there. Works especially poorly for #617 (hard to edit in the small browser address bar)

Additional context
AFAICT element allows it so I don't feel like there's a security concern here. If anything, allowing that as an option is also fine for me...

@yuyichao yuyichao added the enhancement New feature or request label Jun 22, 2021
@deepbluev7
Copy link
Member

deepbluev7 commented Jun 22, 2021

This is not reproducible here. You can copy parts of the message. This is just disabled if you select the mobile mode option, since that interferes with scrolling otherwise.

@deepbluev7
Copy link
Member

(Also you can right click a link to copy it)

@yuyichao
Copy link
Author

You are right #617 (comment) . So the actual enhancement is to improve the touchscreen mode/make it automatic based on the type of input.

@yuyichao
Copy link
Author

In another word, both this and #617 are about improving the touchscreen mode. Feel free to close one/merge them as you see fit.

@deepbluev7
Copy link
Member

Can you create a new issue with the specific improvements for touchscreen mode you would like to see? I.e. if you want to switch touchscreen mode automatically depending on the connected devices or so? Since the title and comment history of this will probably be confusing. It is not possible currently to make text elements only respond to input of specific devices, as far as I am aware, but you can do that for tap handlers and such.

@yuyichao
Copy link
Author

yuyichao commented Sep 4, 2021

Sorry for the delay. My expected 1 week travel was turned into a 2 and a half months one = = ......

I'll test the latest version and see if I think any of the behaviors can be improved though I'm currently hitting Nheko-Reborn/mtxclient#63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants