[WIP] Add factory_bot_remover #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script is really a one time script for searching for files that use `FactoryBot.build` or `FactoryBot.create`, and replace them with the straight `ActiveRecord` equivalents.
NickLaMuro
force-pushed
the
factory_bot_remover
branch
from
21317d4
to
8f41e1b
Compare
Refactoring of this script into a runnable class, but also so it can be used in larger scripts.
Replaces external grep calls with custom some File/IO code. Written in a way where each file being searched is only requires 1 open operation, and only has to load in as much content as is necessary to do the replace (thanks to `.rewind` and `truncate`).
Determines all original factories that need to be replaced, and replaces them across all repos, creating a commit for each factory change.
Allows finding and replacing of FactoryBot calls that are defined acrossed multiple lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script is really a one time script for searching for files that use
FactoryBot.buildorFactoryBot.create, and replace them with the straightActiveRecordequivalents.Might add some more functionality to this to auto commit as well, and search all repos at a time. We will see...