Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling libvips necessary? #76

Open
lemmi opened this issue Sep 17, 2022 · 2 comments
Open

Compiling libvips necessary? #76

lemmi opened this issue Sep 17, 2022 · 2 comments

Comments

@lemmi
Copy link

lemmi commented Sep 17, 2022

I was toying around building the image and the compilation of libvips stood out to me. Since alpine ships a current version as well, I was able to build and the image without these lines:

docker-unms/Dockerfile

Lines 38 to 41 in b710682

&& wget -q https://github.com/libvips/libvips/releases/download/v${LIBVIPS_VERSION}/vips-${LIBVIPS_VERSION}.tar.gz -O libvips.tar.gz \
&& tar -zxvf libvips.tar.gz \
&& cd /tmp/src/vips-${LIBVIPS_VERSION} && ./configure \
&& make && make install \

@Nico640
Copy link
Owner

Nico640 commented Oct 5, 2022

I haven't checked since updating Alpine Linux to 3.15, but the libvips version that shipped with 3.13 was too old for the sharp version used by UISP and since sharp does not offer prebuild libvips binaries for ARMv7 musl, I had to build it from source. So yeah, it's probably not necessary at the moment, however, I like to stay in sync with the versions that the official UISP images uses to minimize these kinds of issues. For example, the official image currently uses libvips 8.12.2, whereas Alpine 3.15 ships with 8.12.1. Maybe I need to rethink this practice at some point or split the image into multiple base images / stages because the fact that building the image can take upwards of an hour is really annoying.

@lemmi
Copy link
Author

lemmi commented Oct 5, 2022

Yes, the build time adds up and this was something that stood out for me. But I can totally understand to play it safe for now, since there is no guarantee this won't run out of sync in the future again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants