Merge pull request #3 from NikiforovAll/2-analyzer-should-check-that-…

…elasticclient-type-is-from-nest-namespace-1 feat: check containing namespace
NikiforovAll · Sep 20, 2024 · 0fb66c9 · 0fb66c9
2 parents f6a7a3f + 99093f7
commit 0fb66c9
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 11 deletions.
diff --git a/analyzer/Nall.NEST.MigtarionAnalyzer.Test/UseElasticsearchNetInsteadOfNestTests.cs b/analyzer/Nall.NEST.MigtarionAnalyzer.Test/UseElasticsearchNetInsteadOfNestTests.cs
@@ -189,6 +189,26 @@ public ElasticsearchService()
 
         await VerifyCS.VerifyCodeFixAsync(test, [expected1, expected2], fixtest);
     }
+
+    [TestMethod]
+    public async Task SameNameButNotFromNamespaceShouldNotAddDiagnostic()
+    {
+        var test = """
+            public class ElasticClient
+            {
+            }
+            public class IElasticClient
+            {
+            }
+
+            public class MyService{
+                private readonly ElasticClient _client1;
+                private readonly IElasticClient _client2;
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(test, []);
+    }
 }
 
 public static class VerifyCS

diff --git a/analyzer/Nall.NEST.MigtarionAnalyzer/UseElasticsearchNetInsteadOfNest.cs b/analyzer/Nall.NEST.MigtarionAnalyzer/UseElasticsearchNetInsteadOfNest.cs
@@ -53,17 +53,17 @@ private static void AnalyzeNode(SyntaxNodeAnalysisContext context)
                 return;
             }
 
-            //var symbolInfo = context.SemanticModel.GetSymbolInfo(identifierNode);
-            //if (symbolInfo.Symbol == null)
-            //{
-            //    return;
-            //}
-            //
-            //var containingNamespace = symbolInfo.Symbol.ContainingNamespace;
-            //if (containingNamespace == null || containingNamespace.ToString() != "Nest")
-            //{
-            //    return;
-            //}
+            var symbolInfo = context.SemanticModel.GetSymbolInfo(identifierNode);
+            if (symbolInfo.Symbol == null)
+            {
+                return;
+            }
+
+            var containingNamespace = symbolInfo.Symbol.ContainingNamespace;
+            if (containingNamespace == null || containingNamespace.ToString() != "Nest")
+            {
+                return;
+            }
 
             var diagnostic = Diagnostic.Create(s_rule, identifierNode.GetLocation());
             context.ReportDiagnostic(diagnostic);

diff --git a/assets/elastic-search-playground-demo2.mp4 b/assets/elastic-search-playground-demo2.mp4