Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed non-embeddable videos being considered not a short #200

Merged
merged 20 commits into from
Jul 29, 2023
Merged

Fixed non-embeddable videos being considered not a short #200

merged 20 commits into from
Jul 29, 2023

Conversation

NikkelM
Copy link
Owner

@NikkelM NikkelM commented Jun 10, 2023

No description provided.

@NikkelM NikkelM self-assigned this Jun 10, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jul 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5701222048

  • 92 of 103 (89.32%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 95.133%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/shuffleVideo.js 92 103 89.32%
Files with Coverage Reduction New Missed Lines %
src/shuffleVideo.js 3 92.68%
Totals Coverage Status
Change from base Build 5630049290: 0.5%
Covered Lines: 1075
Relevant Lines: 1130
💛 - Coveralls

@NikkelM NikkelM changed the title Remember known shorts for faster shuffling Fixed non-embeddable videos being considered deleted Jul 29, 2023
@NikkelM NikkelM marked this pull request as ready for review July 29, 2023 15:38
@NikkelM NikkelM merged commit 60b90b7 into main Jul 29, 2023
1 check passed
@NikkelM NikkelM deleted the faster-shorts branch July 29, 2023 15:39
@NikkelM NikkelM mentioned this pull request Jul 29, 2023
Closed
@NikkelM NikkelM changed the title Fixed non-embeddable videos being considered deleted Fixed non-embeddable videos being considered not a short Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NikkelM NikkelM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikkelM @coveralls