Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember known shorts locally #219

Merged
merged 34 commits into from
Nov 4, 2023
Merged

Remember known shorts locally #219

merged 34 commits into from
Nov 4, 2023

Conversation

NikkelM
Copy link
Owner

@NikkelM NikkelM commented Sep 19, 2023

Closes #208

@NikkelM NikkelM self-assigned this Sep 19, 2023
@NikkelM
Fixed wrong return value if database value is falsy
b82c4f9
@NikkelM
Merge branch 'main' into local-shorts
4398bac
@NikkelM
Updated changelog
3fcab5e
@NikkelM
Updated variables, logs
a86a707
@NikkelM
Added logic for comparing local and database video data sets
d84ad4d
@NikkelM
Added better comments, resolved TODO's
fd06527
@NikkelM
Filtering WIP
01fab15
@NikkelM
Merge branch 'main' into local-shorts
abfbb85
@NikkelM
Use correct filtering
0d184cf
@NikkelM
Removed debug code
2f936fb
@NikkelM
Added button message if ignoring shorts
68c3bce
@NikkelM
Updated version, changelog
fc84178
@NikkelM
Renamed variables
bd65eae
@NikkelM
Test playlists now use the new localPlaylist format
c1afe2d
@NikkelM
Updated playlist names
a5727eb
@NikkelM
Fixed local storage access, test
c86f3d0
@NikkelM
Assigned videos to the correct playlist
7c4a3cf
@NikkelM
Correctly merge playlist objects after fetching from DB
2a60c24
@NikkelM
Fixed playlist access
6d460d9
@NikkelM
Join videos before shuffling
8ae92d2
@NikkelM
More diversity in choosing playlists for testing user settings
24ca7e2
@NikkelM
Fixed some tests
a4ec5ed
@NikkelM
Fixed some tests
7d4b236
@NikkelM
Fixed tests, bugs, removed unnecessary assignment
9d05232
@NikkelM
Fixed, updated tests
8fc1343
@NikkelM
Formatting
fdd432b
@coveralls
Copy link
Collaborator

coveralls commented Nov 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6757666218

  • 141 of 143 (98.6%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 93.983%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/shuffleVideo.js 141 143 98.6%
Files with Coverage Reduction New Missed Lines %
src/shuffleVideo.js 12 92.75%
Totals Coverage Status
Change from base Build 6670195450: -0.003%
Covered Lines: 1187
Relevant Lines: 1263
💛 - Coveralls

@NikkelM NikkelM marked this pull request as ready for review November 4, 2023 22:57
@NikkelM NikkelM merged commit 31403be into main Nov 4, 2023
2 checks passed
@NikkelM NikkelM deleted the local-shorts branch November 4, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NikkelM NikkelM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Shorts] Remember which videos are shorts locally
2 participants
@NikkelM @coveralls