Fix createSlice for reference type

[shermike]

The problem was found when trying to serialize field v []Uint256, where Uint256 is a struct with SSZ interface.

[shermike]

@KlonD90 could you please check this changes in JS? So we can be sure that it won't break anything.

[olegrok]

Anyway let's wait @KlonD90's decision about compatibility with JS library

[olegrok]

I'd add some tests to current test suite (it will be checked inside our project but anyway...)

Also seems we need to fix error messages for this case...

fastssz/encode.go

Lines 303 to 309 in 93b9cf0

	num, ok := DivideInt(a, b)
	if !ok {
	return 0, fmt.Errorf("xx")
	}
	if num > max {
	return 0, fmt.Errorf("yy")
	}

[shermike]

What is the error message?

[olegrok]

Seems in case if user passes malformed input or adds more elements than limit allows it will get "xx" or "yy" as an error message.

It's not related to your patch directly, it's just interesting moment.

[shermike]

I see, let's do it later.
About tests, I tried to find a place in fastssz where to make them, but no luck. Let's push it as is and see what we'll need.

[KlonD90]

IDK how it would effect. Do you have an example of encoding generated? If it's plain data and also hash level plain too it wouldn't affect

[KlonD90]

I think that you could merge it. We don't have a []Uint256 in external message. It shouldn't break anything except check that data field could be read another way?