You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now we agreed to name libraries like zkEVM<LIBNAME>. This is actually slightly inconvenient, because:
zkEVM-framework sources are not designed to be included as a dependency into other project. Possible user would rather build and install it. With that in mind, having library names like DataTypes and MPT is fine for us, because we will unlikely face name collisions. So, this prefix is not really needed;
When using installed version of zkEVM-framework, imported with CMake, you will get namespaced names like:
zkEVM-framework::MPT
And with if the prefix will be there, you would get
zkEVM-framework::zkEVMMPT
which is a bit awkward;
zkEVM is not a precise prefix, it probably should be zkEVM-framework instead.
What we can do:
Get rid of this prefix completely. So instead of target zkEVMDataTypes we will have DataTypes as a build target and zkEVM-framework::DataTypes as exported target;
or
Switch to zkEVMFramework prefix. So instead of zkEVMDataTypes we will have zkEVMFrameworkDataTypes.
Note: target exporting is not yet implemented. See #27
For me best naming is zkEVM-framework::DataTypes
Nobody uses Framework as external dependency, and most probably will not, so enabling export target just nice to have.
Renaming libraries should be separate task in my understanding
This discussion was converted from issue #73 on July 16, 2024 15:42.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Now we agreed to name libraries like
zkEVM<LIBNAME>
. This is actually slightly inconvenient, because:zkEVM-framework sources are not designed to be included as a dependency into other project. Possible user would rather build and install it. With that in mind, having library names like
DataTypes
andMPT
is fine for us, because we will unlikely face name collisions. So, this prefix is not really needed;When using installed version of zkEVM-framework, imported with CMake, you will get namespaced names like:
And with if the prefix will be there, you would get
which is a bit awkward;
zkEVM
is not a precise prefix, it probably should bezkEVM-framework
instead.What we can do:
zkEVMDataTypes
we will haveDataTypes
as a build target andzkEVM-framework::DataTypes
as exported target;or
zkEVMFramework
prefix. So instead ofzkEVMDataTypes
we will havezkEVMFrameworkDataTypes
.Note: target exporting is not yet implemented. See #27
Beta Was this translation helpful? Give feedback.
All reactions