Remove the need for PathBuilder
#267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is quite a rudimentary solution that involves too many traits. A minimal solution is needed to simplify the code. Fix test
`ShapePath` is a `Geometry` that can be fed to `ShapeBuilder`. This makes `PathBuilder` redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows
ShapeBuilderto build custom paths.PathBuilderhas been removed. Paths can be constructed withShapePath, and then be feeded toShapeBuilder.Since normal shapes uses Lyon's type
NoAttribute<BuilderImpl>while paths useWithSvg<BuilderImpl>, I madeGeometrygeneric over these.