Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to mock organization #112

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kkurczewski
Copy link

As per #109

@kkurczewski
Copy link
Author

Hello @jnizet

As agreed I removed references to Ninja Squad from code. If there is something else you want to change please feel free to correct PR.

Regarding next step, according Github docs you should have an option in settings to transfer repo to mockk org and then either @oleksiyp or @Raibaz can accept the transfer on their side.

@jnizet
Copy link
Member

jnizet commented Feb 7, 2024

My guess is that they will want to include the code in their existing repo, as a subproject of the MockK project. Not just take control of my repo. I'll let them tell me if I need to do something.

@kkurczewski
Copy link
Author

Okay. I don't wanna force you to do any action. Just googled up what options offers Github itself and thought it may be best (due auto-redirect for example).

@djkeh
Copy link

djkeh commented Feb 8, 2024

If this is going to happen, I'll take care of my prior pr #110 and #111 after moving in to mockk.io.

@oleksiyp
Copy link

oleksiyp commented Feb 11, 2024

I strarted inclusion as a module of mockk here. Will try to make it buildable and publishable in this PR

@oleksiyp
Copy link

oleksiyp commented Feb 11, 2024

PR is passing all springmockk tests, not 100% sure that it has publishable artifact in maven(possible to check upon release), but generally it should be so.
@jnizet @kkurczewski @Raibaz please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants