Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all NK Pro curves #484

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Conversation

sosthene-nitrokey
Copy link
Collaborator

@sosthene-nitrokey sosthene-nitrokey commented Apr 24, 2024

  • NIST P256
  • NIST P384
  • NIST P521
  • Brainpool P256r1
  • Brainpool P384r1
  • Brainpool P512r1

Pending:

Due to binary size constraints the curves are only supported on Opcard with the SE050 enabled.

Brainpool 512 and NIST P521 are disabled pending response from NXP support for the export failure on the SE050.

Currently they are only enabled in test releases.

@nitrokey-ci
Copy link
Collaborator

nitrokey-ci commented Jul 9, 2024

No significant changes.

Insignifcant changes
metric value change
binary-size-nk3am 1,408,891 🔴 +9,458 (+0.68%)
binary-size-nk3am-test 2,012,781 🔴 +8,362 (+0.42%)
binary-size-nk3xn 505,444 🔴 +2,900 (+0.58%)
binary-size-nk3xn-test 579,592 🔴 +2,644 (+0.46%)
binary-size-nkpk 729,160 🔴 +1,726 (+0.24%)

@sosthene-nitrokey sosthene-nitrokey changed the title Enable p384 and p521 in trussed. Support all NK Pro curves Jul 16, 2024
@sosthene-nitrokey sosthene-nitrokey marked this pull request as ready for review July 17, 2024 14:19
@sosthene-nitrokey sosthene-nitrokey merged commit be90303 into main Jul 31, 2024
9 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the trussed-p384-p521-software branch July 31, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants