-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct increased memory usage #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, but it appears that not all commands use references (for example CommandOpenPGPInfoResponse
does not).
That's correct - I was prioritizing the failing command first. Will finish that in the next steps. |
Protip to check the size of the types: Then you can peek into |
To add, these were informative for me too:
I think, that |
Connected: Nitrokey/nitrokey-3-firmware#312 |
Co-authored-by: sosthene-nitrokey <109070476+sosthene-nitrokey@users.noreply.github.com>
There were no heavy changes since the last review, only some clean up. I plan to merge the current state as-is, in a squashed commit. |
Correct increased memory usage by using references instead of the heapless buffers, and switching to serde_bytes for the serialization.