Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientFilestore: make dat optional #34

Closed
wants to merge 2 commits into from
Closed

Commits on Mar 5, 2024

  1. read_dir_first: stop at the first file that is alphabetically "after"…

    … `not_before`
    
    In fido-authenticator, if we change the paths of RK  to be:
    "rp_id.rk_id" instead of the current "rp_id/rk_id", we still want to be able
    to iterate over the keys even though we only  know the "rp_id" and not the
    "rk_id". Therefore we need to be able to stop at "rp_id.***" when giving "rp_id" in `not_before`
    
    This is technically a breaking change because now, given the files:
    
    - "aaa"
    - "aaabbb"
    
     "read_dir_first"  with "aaa" as `not_before` would only yield "aaa"
    due to littlefs-project/littlefs#923.
    Now this will yield both files, and yield "aaabbb" first.
    
    I beleive this behaviour is technically more correct as it is likely what
    would be expected to be yield expecting alphabetical order
    (though the order of the entries is still incorrect).
    sosthene-nitrokey committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    dadeda9 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    371e8f7 View commit details
    Browse the repository at this point in the history