Merge upstream changes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
robin-nitrokey
commented
Mar 4, 2024
robin-nitrokey
commented
- Add must_use attributes on futures. trussed-dev/trussed#146
- Run cargo fmt trussed-dev/trussed#147
- Add nonce to wrap_key and unwrap_key syscalls trussed-dev/trussed#148
- Use nonce as IV for Aes256Cbc mechanism trussed-dev/trussed#149
Older version of Rust failed to format `service.rs` file.
Prior to that there would be no warning when forgetting to use `(try_)syscall`.
This patch adds a nonce argument to the wrap_key and unwrap_key syscalls to be able to use the Aes256Cbc mechanism with a non-zero IV in the future.
sosthene-nitrokey
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.