Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/functional/flakes/run: fix tests in macOS devshell #11602

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 27, 2024

same fix as in 04a47e9

Motivation

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Sep 27, 2024
@edolstra
Copy link
Member

I suppose it would be nice to deduplicate this code, maybe it could be moved to tests/functional/common?

@Mic92
Copy link
Member Author

Mic92 commented Sep 27, 2024

I just don't know what a good name would be, assertEnvEqual?

Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is anything setting TMPDIR? This could be a bug or regression

Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, already reported. To be fixed. Let's unblock the dev workflow first.

tests/functional/flakes/run.sh Outdated Show resolved Hide resolved
@roberth roberth merged commit c116030 into NixOS:master Sep 30, 2024
11 checks passed
@Mic92 Mic92 deleted the macos-test-fix branch September 30, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants