Skip to content

Commit

Permalink
Merge pull request #327380 from NixOS/backport-321010-to-release-24.05
Browse files Browse the repository at this point in the history
[Backport release-24.05] virtualboxKvm: 20240515 -> 20240617
  • Loading branch information
JohnRTitor authored Aug 21, 2024
2 parents aea6e7b + f6a8567 commit b538a69
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 18 deletions.
14 changes: 1 addition & 13 deletions nixos/modules/virtualisation/virtualbox-host.nix
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ in
Enable KVM support for VirtualBox. This increases compatibility with Linux kernel versions, because the VirtualBox kernel modules
are not required.
This option is incompatible with `enableHardening` and `addNetworkInterface`.
This option is incompatible with `addNetworkInterface`.
Note: This is experimental. Please check https://github.com/cyberus-technology/virtualbox-kvm/issues.
'';
Expand Down Expand Up @@ -136,18 +136,6 @@ in
assertion = !cfg.addNetworkInterface;
message = "VirtualBox KVM only supports standard NAT networking for VMs. Please turn off virtualisation.virtualbox.host.addNetworkInterface.";
}

{
assertion = !cfg.enableHardening;
message = "VirtualBox KVM is not compatible with hardening: Please turn off virtualisation.virtualbox.host.enableHardening.";
}
];

warnings = [
''
KVM support in VirtualBox is experimental. Not all security features are available yet.
See: https://github.com/cyberus-technology/virtualbox-kvm/issues/12
''
];
}) (mkIf (!cfg.enableKvm) {
boot.kernelModules = [ "vboxdrv" "vboxnetadp" "vboxnetflt" ];
Expand Down
7 changes: 2 additions & 5 deletions pkgs/applications/virtualization/virtualbox/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
, extraConfigureFlags ? ""
}:

# See https://github.com/cyberus-technology/virtualbox-kvm/issues/12
assert enableKvm -> !enableHardening;

# The web services use Java infrastructure.
assert enableWebService -> javaBindings;

Expand All @@ -35,8 +32,8 @@ let
virtualboxVersion = "7.0.18";
virtualboxSha256 = "d999513533631674a024762668de999411d8197060c51e68c5faf0a2c0eea1a5";

kvmPatchVersion = "20240515";
kvmPatchHash = "sha256-Kh/tlPScdf7CbEEpL54iqMpeUIdmnJL2r/mxnlEzLd0=";
kvmPatchVersion = "20240617";
kvmPatchHash = "sha256-bOcM9xA1SXB1uTwljpw2vevVeSdHa3omCRon/8DoAUk=";

# The KVM build is not compatible to VirtualBox's kernel modules. So don't export
# modsrc at all.
Expand Down

0 comments on commit b538a69

Please sign in to comment.