Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.dash-to-dock: switch to fork to make it work with GNOME 40 #135293

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

mohe2015
Copy link
Contributor

@mohe2015 mohe2015 commented Aug 22, 2021

Motivation for this change

Extension doesn't work at all currently.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Aug 22, 2021
@SuperSandro2000 SuperSandro2000 merged commit 8aa249c into NixOS:master Aug 23, 2021
@mohe2015 mohe2015 deleted the fix/gnome/dash-to-dock branch August 23, 2021 10:02
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/cant-seem-to-use-make-due-to-glib-compile-schemas/14866/2

@mohe2015
Copy link
Contributor Author

mohe2015 commented Sep 5, 2021

Should we possibly backport this if it's also not working at all in 21.05?

@jtojnar
Copy link
Member

jtojnar commented Sep 6, 2021

This is still unfinished branch and it is quite buggy.

@mohe2015
Copy link
Contributor Author

mohe2015 commented Oct 7, 2021

Should this be reverted after branchoff? I'm not using gnome anymore but I don't know if we want this buggy unofficial forks in a release. Not working at all is not good either though.

@mohe2015
Copy link
Contributor Author

mohe2015 commented Oct 7, 2021

On my phone so I didn't see this at first but micheleg/dash-to-dock#1402 (comment) there probably will be a release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants