Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.testpath: fix tests on Darwin #145276

Merged

Conversation

austinbutler
Copy link
Member

@austinbutler austinbutler commented Nov 9, 2021

Motivation for this change

Works around jupyter/testpath#24.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@austinbutler
Copy link
Member Author

@SuperSandro2000 mind taking another look?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 3, 2021

@ofborg build python39Packages.testpath

@SuperSandro2000
Copy link
Member

python3Minimal fails on staging so it is quite hard to validate if this change works or not.

@austinbutler
Copy link
Member Author

python3Minimal fails on staging so it is quite hard to validate if this change works or not.

Yes I just found that as well locally when testing unrelated things. Seems like a patch fails to apply.

@austinbutler
Copy link
Member Author

I think it may be that both #146477 and #145752 were merged in staging, but I don't think Python 3.9.9 needs the bpo-44689 patch.

@austinbutler
Copy link
Member Author

#148519 likely fixed that problem.

@ofborg build python39Packages.testpath

@SuperSandro2000 SuperSandro2000 merged commit 1c5c21e into NixOS:staging Dec 5, 2021
@austinbutler austinbutler deleted the testpath-fix-socket-error branch December 6, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants