-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.testpath: fix tests on Darwin #145276
Merged
SuperSandro2000
merged 1 commit into
NixOS:staging
from
austinbutler:testpath-fix-socket-error
Dec 5, 2021
Merged
python3Packages.testpath: fix tests on Darwin #145276
SuperSandro2000
merged 1 commit into
NixOS:staging
from
austinbutler:testpath-fix-socket-error
Dec 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
Running or building packages on Darwin
10.rebuild-darwin: 501+
10.rebuild-darwin: 1001-2500
10.rebuild-linux: 501+
10.rebuild-linux: 1001-2500
labels
Nov 9, 2021
austinbutler
force-pushed
the
testpath-fix-socket-error
branch
from
November 10, 2021 17:42
ad331cf
to
2f314c8
Compare
@SuperSandro2000 mind taking another look? |
austinbutler
force-pushed
the
testpath-fix-socket-error
branch
from
December 1, 2021 19:26
2f314c8
to
869814f
Compare
@ofborg build python39Packages.testpath |
python3Minimal fails on staging so it is quite hard to validate if this change works or not. |
Yes I just found that as well locally when testing unrelated things. Seems like a patch fails to apply. |
austinbutler
force-pushed
the
testpath-fix-socket-error
branch
from
December 4, 2021 21:21
869814f
to
a32a76f
Compare
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: darwin
Running or building packages on Darwin
6.topic: python
10.rebuild-darwin: 501+
10.rebuild-darwin: 1001-2500
10.rebuild-linux: 501+
10.rebuild-linux: 1001-2500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Works around jupyter/testpath#24.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)