cmake: fix crash on CC without libc support #187777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change pkgsLLVM fails to build any packages
as compiler-rt fails early in cmake:
CMake Error at ...-cmake-3.24.0/share/cmake-3.24/Modules/Platform/UnixPaths.cmake:53 (file):
file STRINGS file
"...-x86_64-unknown-linux-gnu-clang-wrapper-11.1.0/nix-support/orig-libc-dev"
cannot be read.
It's a regression caused by 871cf9f "cmake: detect libc location
at runtime NixOS#181431" where we started using `orig-libc-dev` as a libc pointer.
During pkgsLLVM pootstrap first compiler has no libc support yet.
The change skips runtime detection if there are no libc signs.
This was referenced Aug 21, 2022
|
Tested successfully on |
stephank
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change pkgsLLVM fails to build any packages
as compiler-rt fails early in cmake:
It's a regression caused by 871cf9f "cmake: detect libc location
at runtime #181431" where we started using
orig-libc-devas a libc pointer.During pkgsLLVM pootstrap first compiler has no libc support yet.
The change skips runtime detection if there are no libc signs.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes