-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/zammad: refactor package, module and nixos-test #277456
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a clever change. I like that it leaves more things in the nix store rather than copied into runtime directories.
054cef4
to
cb538a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it, but the code looks good to me.
cb538a2
to
9f65e94
Compare
Did a rebase, since what was there conflicted in a few places. @Radvendii PTAL and ping me to merge. |
9f65e94
to
51f8cd4
Compare
Description of changes
This PR refactors the Zammad package, NixOS module and NixOS test. It does the following things:
inherit (lib) ...
instead ofwith lib;
zammad-web
unit hard depended on a local PostgreSQL database (especially in the check if a database initialization is required)preScript
of thezammad-web
unit to clean the old package contents out of the state directoryThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.