Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vep: init at 110 #283317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vep: init at 110 #283317

wants to merge 1 commit into from

Conversation

apraga
Copy link
Contributor

@apraga apraga commented Jan 23, 2024

This software has required significant work to package and need other PR to be merge beforehand : #185691 #186459 #186464 and the infamous #186462.
The package has been formatted with nixpkgs-fmt. I was not able to run tests but this software has been used for hundred of runs in research setting.

Description of changes

New packages for Variant Effect Predictor.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3701

pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
@apraga apraga force-pushed the vep-110 branch 2 times, most recently from 9931023 to 600008e Compare March 28, 2024 22:44
@apraga
Copy link
Contributor Author

apraga commented Mar 28, 2024

Thanks for your review. Your changes have been incorporated. I've also switched to using the release version (with fetchzip as it's not available with fetchfromgithub) instead of git commits. Code have been formatted with nixfmt-rfc-style. The changes are in a separated commit for readability.

pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
@apraga
Copy link
Contributor Author

apraga commented Mar 31, 2024

Oops, somehow I forgot to clean references to pkgs. Thanks !

@apraga
Copy link
Contributor Author

apraga commented Jun 29, 2024

@rhendric If you have time to take another look at this PR, that would be great. Thanks !

pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Show resolved Hide resolved
pkgs/by-name/ve/vep/package.nix Outdated Show resolved Hide resolved
@apraga
Copy link
Contributor Author

apraga commented Jul 2, 2024

@rhendric Okay, this should be better, thanks !

@apraga
Copy link
Contributor Author

apraga commented Aug 31, 2024

@rhendric If you have some time to look at it, it would be great :)

@apraga
Copy link
Contributor Author

apraga commented Sep 7, 2024

@rhendric When testing the package, the binaries are not installed. Not sure how it worked before (we used it in production) but this has been fixed. If you have any comment about the wrapping, please tell me.
Edit: tested with vep -i homo_sapiens_GRCh38.vcf --cache . --merged

Version number use Ensembl major version.
@apraga
Copy link
Contributor Author

apraga commented Oct 26, 2024

@rhendric I've merged the commits and rebase against master. Do you think we can (finally) put this PR to rest ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants