-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vep: init at 110 #283317
base: master
Are you sure you want to change the base?
vep: init at 110 #283317
Conversation
ae8cc36
to
e53a320
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3701 |
9931023
to
600008e
Compare
Thanks for your review. Your changes have been incorporated. I've also switched to using the release version (with fetchzip as it's not available with fetchfromgithub) instead of git commits. Code have been formatted with nixfmt-rfc-style. The changes are in a separated commit for readability. |
Oops, somehow I forgot to clean references to |
@rhendric If you have time to take another look at this PR, that would be great. Thanks ! |
@rhendric Okay, this should be better, thanks ! |
@rhendric If you have some time to look at it, it would be great :) |
@rhendric When testing the package, the binaries are not installed. Not sure how it worked before (we used it in production) but this has been fixed. If you have any comment about the wrapping, please tell me. |
Version number use Ensembl major version.
@rhendric I've merged the commits and rebase against master. Do you think we can (finally) put this PR to rest ? :) |
This software has required significant work to package and need other PR to be merge beforehand : #185691 #186459 #186464 and the infamous #186462.
The package has been formatted with nixpkgs-fmt. I was not able to run tests but this software has been used for hundred of runs in research setting.
Description of changes
New packages for Variant Effect Predictor.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.