python312Packages.docarray: init at 0.40.0 #296615
Conversation
|
Added optional dependencies but could not find yet why tests are not collected. |
|
Just realized that tests are not collected because they are not shipped in the Pypi distribution... What is considered best practice in that case? Fetching from GitHub to get the tests or fetching from Pypi to get the official release? |
loicreynier
force-pushed
the
feat-python3-docarray-init-at-0.40
branch
from
8610f5a
to
0d8d168
Compare
|
Squashed commits together, formatted with |
There was a problem hiding this comment.
Just realized that tests are not collected because they are not shipped in the Pypi distribution... What is considered best practice in that case? Fetching from GitHub to get the tests or fetching from Pypi to get the official release?
Please fetch the source from GitHub.
loicreynier
force-pushed
the
feat-python3-docarray-init-at-0.40
branch
from
0d8d168
to
b1c0a0e
Compare
|
Result of 4 packages built:
|
loicreynier
force-pushed
the
feat-python3-docarray-init-at-0.40
branch
from
b1c0a0e
to
e79e62e
Compare
|
Removed LangChain extra dependency following #319079. |
| }; | ||
|
|
||
| pythonImportsCheck = [ "docarray" ]; | ||
|
|
There was a problem hiding this comment.
Could you add pytestCheckHook to nativeCheckInputs?
There was a problem hiding this comment.
A lot of tests depend on Python packages that are not available yet in nixpkgs. Even listing the tests names (to list them in disabledTests) is not possible without the dependencies. I can't find a way to disable the problematic tests.
There was a problem hiding this comment.
I have successfully packaged the missing Python packages locally, i.e. mktestdocs and pyepsilla. All the tests work with them. Should I push them to nixpkgs before finishing (and fixing) this PR?
There was a problem hiding this comment.
You could include both into this PR if possible 👍
There was a problem hiding this comment.
pyepsilla depends on #338831 and on the latest version of posthog that should be updated by auto updates.
There was a problem hiding this comment.
Actually, mktestdocs has been added by #338197.
loicreynier
force-pushed
the
feat-python3-docarray-init-at-0.40
branch
from
9db41a8
to
19dd6d9
Compare
|
As mentioned above, DocArray tests fail because test (collection and run) require I added |
loicreynier
changed the title
Co-authored-by: OTABI Tomoya <tomoya.otabi@gmail.com>
loicreynier
force-pushed
the
feat-python3-docarray-init-at-0.40
branch
from
4b14d8a
to
0612a4c
Compare
Description of changes
Add DocArray a Python library for multimodal data.
Currently,
pytestcollection do not work.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.