-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-23.11]: cargo-* tools updates with newer rustPlatform #298312
Merged
matthiasbeyer
merged 62 commits into
NixOS:release-23.11
from
matthiasbeyer:backport-cargo-tools-updates-with-newer-rustc
Apr 22, 2024
Merged
[Backport release-23.11]: cargo-* tools updates with newer rustPlatform #298312
matthiasbeyer
merged 62 commits into
NixOS:release-23.11
from
matthiasbeyer:backport-cargo-tools-updates-with-newer-rustc
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2024
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Mar 28, 2024
matthiasbeyer
force-pushed
the
backport-cargo-tools-updates-with-newer-rustc
branch
2 times, most recently
from
April 2, 2024 11:23
65c8a3f
to
41da92b
Compare
Friendly ping @figsoda @06kellyjac @oxalica @B4dM4n @kharji |
1 task
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit a2b9457) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit ffe99f3) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit 0c9dbdf) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Diff: https://diff.rs/cargo-tally/1.0.33/1.0.34 Changelog: https://github.com/dtolnay/cargo-tally/releases/tag/1.0.34 (cherry picked from commit 29eabaf) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit 1360af0) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit 782350f) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit 68ee883) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit dd2251d) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit 7f4bca6) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit aa68800) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit f4a2170) Signed-off-by: Matthias Beyer <mail@beyermatthias.de> (cherry picked from commit 26654903ab8423819096691ef0dc6eca352be4cd) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit ec7438f) Signed-off-by: Matthias Beyer <mail@beyermatthias.de> (cherry picked from commit edc26b1a1e7a1849b310f84d9fd03bca41d40c27) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Result of 12 packages built:
|
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit be86ca7) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This was referenced Apr 14, 2024
Result of 13 packages built:
|
(cherry picked from commit 30c60b8) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
kkharji
approved these changes
Apr 21, 2024
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
skip failing tests (cherry picked from commit 821fa71) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This was referenced Apr 21, 2024
I'll merge this tomorrow if there's no objections. |
Result of 1 package failed to build:
13 packages built:
|
Turns out |
Result of 13 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This was extracted from #298302 to be able to talk in a dedicated PR about the following issue:
The backports are only possible because of #298206 - that's why there are patches in this PR that make the updated attributes use the
rustPackages_1_76.rustPlatform
to build the packages. The patches that make this change are not onmaster
, so I don't know what the policy for such a backport is.All other patches (the actual package update commits) are
cherry-pick -xs
ed.I did not (yet) run this through
nixpkgs-review
as #298206 has not yet landed onnixos-23.11
, and I don't want to recompilerustc
on my infra 😆Once
nixos-23.11
is updated, I can of course do anixpkgs-review
run on this.Lets discuss.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.