nagiosPlugins: init from pkgs/servers/monitoring/nagios/plugins

[anthonyroussel]

Description of changes

This pull request aims to improve the organization of Nagios plugins in our repository by creating a dedicated nagiosPlugins attribute set.

1. Grouping Nagios Plugins: Created a dedicated attribute nagiosPlugins in the all-packages.nix file to group all existing Nagios plugins together (check_smartmon, check_systemd, check_zfs, and check_ssl_cert)

2. Formatted Nagios plugins with nixfmt-rfc-style

3. Upgraded check_systemd to 4.1.0: Josef-Friedrich/check_systemd@v2.3.1...v4.1.0

4. Upgraded check_esxi_hardware to 20221230: Napsty/check_esxi_hardware@2020071...2022123

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[anthonyroussel]

@ofborg build nagiosPlugins

[oxzi]

Thank you very much for this pull request and for having the courage to restructure stuff. I came across your PR while searching for existing work to update check_systemd.

Your commit-by-commit breakdown was especially helpful in understanding your thought process. Thank you again for your hard work!

I left a few comments where I thought changes were needed, mostly related to an incorrectly converted license.

I only built check_systemd, as it was the check plugin I was looking for, and it worked as expected.

To keep things simple, I would advise against bumping packages any further, unless the upstream has been locked, as I commented.

[oxzi]

This repository is dead since October 2021, speartail/checkwmiplus@37fa4f9.

On a first glance I was unable to find another repository, but tarballs on the author's webpage: https://edcint.co.nz/checkwmiplus/releases/

[oxzi]

#301654

[anthonyroussel]

Hello @oxzi
Thank you very much for the review :)

I've corrected the incorrect licenses on the 3 packages.

For the check_wmi_plus plugin, since the Git repository is no longer updated and it's no longer possible to diff easily between 2 versions, I'm not very confident about updating this plugin (update, "audit" upstream code & test the package) based on a tar.gz file hosted on a rather obscure Wordpress site, on my side unfortunately.

I suggest that we update this plugin in another PR instead.
What do you think?

[oxzi]

Thanks for your fast reply!

I've corrected the incorrect licenses on the 3 packages.

Merci.

For the check_wmi_plus plugin, since the Git repository is no longer updated and it's no longer possible to diff easily between 2 versions, I'm not very confident about updating this plugin (update, audit upstream code & test the package) based on a tar.gz file hosted on a rather obscure Wordpress site, on my side unfortunately.

I suggest that we update this plugin in another PR instead. What do you think?

I completely understand your concerns and I think your suggestion is a fine one, keep the package as it is. Perhaps you could add a comment above the src block? I would recommend against labeling it as broken, since it technically isn't. Additionally, I have created issue #301654 to keep track of this package.

[anthonyroussel]

I completely understand your concerns and I think your suggestion is a fine one, keep the package as it is. Perhaps you could add a comment above the src block? I would recommend against labeling it as broken, since it technically isn't. Additionally, I have created issue #301654 to keep track of this package.

Thanks for creating the issue ticket.

Sure, I just added comment above the src block to indicate that upstream has been moved.

[oxzi]

Thanks again! After having some hours of sleep, I looked at the changes again and they look good to me. Furthermore, I have tested building all packages and checked what happened when trying to build one of the now aliased packages. Looks good to me!

$ git rev-parse HEAD
559497dbb9ac3e5e3d7b4d7af2aca03155c559d5

$ nix-build -A nagiosPlugins
/nix/store/g7ry2rgiihhrjas9nma9gzxm2rc04r45-check_esxi_hardware-20221230
/nix/store/4xl1pkp3q6f2fj4j52ycgn45ixc7np8k-check_mssql_health-2.6.4.15
/nix/store/g4nmm8qv9q5dqgz6n0s57qdh4jsbxrkr-check_nwc_health-7.10.0.6
/nix/store/0dh1fbyl2y83wkcjgwgzx7l3513qnc2b-check_openvpn-0.0.1
/nix/store/ipksi0529nj4na81bpaxcax4akla7lis-check_smartmon-1.0.1
/nix/store/dd1gqs8fxavi6vdkyv3vg52g51b83j4c-check_ssl_cert-2.81.0
/nix/store/rrcnlcxm17c0j00m2cw703214ns0dvpd-check_systemd-4.1.0
/nix/store/kn1a4bc9sr0af2xqnc56m23hlbzxdwll-check_ups_health-2.8.3.3
/nix/store/xx6ybjx2lfvab0hmdjm5pkwcaccbkxcw-check_uptime-unstable-2016-11-12
/nix/store/b6svpmx5j9x9ww7hi34b8590nn093k4x-check_wmi_plus-1.65
/nix/store/yvg8qzjky77rg33jzjgxgaf5xn1z8pi0-check_zfs-2.0

$ nix-build -A monitoring-plugins
/nix/store/ks6afw75qpa156pv7sdkczfwx4bgydh0-monitoring-plugins-2.3.5

$ for i in check_smartmon check_systemd check_zfs check-esxi-hardware check-mssql-health check-nwc-health check-openvpn check-ups-health check-uptime check-wmiplus checkSSLCert; do nix-build -A "$i"; done
trace: warning: 'check_smartmon' has been renamed to 'nagiosPlugins.check_smartmon'
/nix/store/ipksi0529nj4na81bpaxcax4akla7lis-check_smartmon-1.0.1
trace: warning: 'check_systemd' has been renamed to 'nagiosPlugins.check_systemd'
/nix/store/rrcnlcxm17c0j00m2cw703214ns0dvpd-check_systemd-4.1.0
trace: warning: 'check_zfs' has been renamed to 'nagiosPlugins.check_zfs'
/nix/store/yvg8qzjky77rg33jzjgxgaf5xn1z8pi0-check_zfs-2.0
trace: warning: 'check-esxi-hardware' has been renamed to 'nagiosPlugins.check_esxi_hardware'
/nix/store/g7ry2rgiihhrjas9nma9gzxm2rc04r45-check_esxi_hardware-20221230
trace: warning: 'check-mssql-health' has been renamed to 'nagiosPlugins.check_mssql_health'
/nix/store/4xl1pkp3q6f2fj4j52ycgn45ixc7np8k-check_mssql_health-2.6.4.15
trace: warning: 'check-nwc-health' has been renamed to 'nagiosPlugins.check_nwc_health'
/nix/store/g4nmm8qv9q5dqgz6n0s57qdh4jsbxrkr-check_nwc_health-7.10.0.6
trace: warning: 'check-openvpn' has been renamed to 'nagiosPlugins.check_openvpn'
/nix/store/0dh1fbyl2y83wkcjgwgzx7l3513qnc2b-check_openvpn-0.0.1
trace: warning: 'check-ups-health' has been renamed to 'nagiosPlugins.check_ups_health'
/nix/store/kn1a4bc9sr0af2xqnc56m23hlbzxdwll-check_ups_health-2.8.3.3
trace: warning: 'check-uptime' has been renamed to 'nagiosPlugins.check_uptime'
/nix/store/xx6ybjx2lfvab0hmdjm5pkwcaccbkxcw-check_uptime-unstable-2016-11-12
trace: warning: 'check-wmiplus' has been renamed to 'nagiosPlugins.check_wmi_plus'
/nix/store/b6svpmx5j9x9ww7hi34b8590nn093k4x-check_wmi_plus-1.65
trace: warning: 'checkSSLCert' has been renamed to 'nagiosPlugins.check_ssl_cert'
/nix/store/dd1gqs8fxavi6vdkyv3vg52g51b83j4c-check_ssl_cert-2.81.0

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1586

[anthonyroussel]

@SuperSandro2000 Thank you for your review! I handled all your feedbacks.

[anthonyroussel]

I was just wondering if I should rename the nagiosPlugins attribute set to nagiosPackages instead to be consistent. What do you think?

[anthonyroussel]

Rebased against master branch and solved conflicts

[oxzi]

Nice to see this getting merged. I mean.. if the original reviewer w/ merge rights did not respond, then it's easier to get merge rights yourself :)

[SuperSandro2000]

This should have a 0- prefix

[SuperSandro2000]

This should be postPatch

[SuperSandro2000]

pname should not be substituted in urls

[SuperSandro2000]

Those should reference the new packages instead of using throws

[SuperSandro2000]

Nice to see this getting merged. I mean.. if the original reviewer w/ merge rights did not respond, then it's easier to get merge rights yourself :)

As hard as it sounds, Nagios just does not have a priority in the flood of review requests I receive on a daily and it is not great that this happened like this with the 5 comments I immediately saw above.

[anthonyroussel]

Thank you for the review! @SuperSandro2000 :)
I created PR #351008 to fix these problems introduced with my PR.