[23.11] glibc: 2.38-44 -> 2.38-66 #304878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LeSuisse since eval seems to time out, I didn't get a ping and was about to prepare the fix on my own. Would it be OK for you to ping me directly on such PRs in the future? :) |
|
Sorry about that, I thought I had explicitly requested you as a reviewer when creating the PR but it looks like I only did for the PR targeting |
Ma27
approved these changes
Apr 18, 2024
|
I thought timeouts are not hard errors? Double checking the lib tests locally... |
|
OK, tests are passing indeed. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/why-is-unpatched-glibc-2-38-44-still-on-latest-stable-23-11/44746/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes GLIBC-SA-2024-0004 (CVE-2024-2961).
https://sourceware.org/git/?p=glibc.git;a=blob;f=advisories/GLIBC-SA-2024-0004;h=23a8115d63218b5e8985ecdfcc471632e347b225;hb=refs/heads/master
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.