Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acpica-tools: 20230628 -> 20240322, build from source repo #305399

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

LeSuisse
Copy link
Contributor

Description of changes

Changes:
https://github.com/acpica/acpica/blob/G20240322/documents/changes.txt

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@delroth delroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already built from source, I think by that you mean that you're switching to repo checkout instead of upstream tarball?

@LeSuisse LeSuisse changed the title acpica-tools: 20230628 -> 20240322, build from sources acpica-tools: 20230628 -> 20240322, build from source repo Apr 19, 2024
@LeSuisse
Copy link
Contributor Author

Yep, it looks like building from the repo checkout is fine and from what they say in the GH release notes it seems the tarball on their website might lag behind.

@ofborg ofborg bot requested a review from delroth April 20, 2024 00:01
@delroth delroth merged commit 5fd470c into NixOS:master Apr 20, 2024
25 of 26 checks passed
@LeSuisse LeSuisse deleted the acpica-tools-20240322 branch April 20, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants