Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-23.11] vscode-extensions: format using nixfmt-rfc-style #305671

Merged
merged 2 commits into from
Apr 21, 2024
Merged

[Backport release-23.11] vscode-extensions: format using nixfmt-rfc-style #305671

merged 2 commits into from
Apr 21, 2024

Conversation

SebTM
Copy link
Contributor

@SebTM SebTM commented Apr 21, 2024

Description of changes

Backport of #305560

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SebTM SebTM requested a review from jonringer as a code owner April 21, 2024 05:12
@SebTM SebTM changed the base branch from nixos-23.11 to release-23.11 April 21, 2024 05:13
@SebTM SebTM changed the title vscode-extensions: format using nixfmt-rfc-style [Backport] vscode-extensions: format using nixfmt-rfc-style Apr 21, 2024
@SebTM SebTM changed the title [Backport] vscode-extensions: format using nixfmt-rfc-style [Backport release-23.11] vscode-extensions: format using nixfmt-rfc-style Apr 21, 2024
@superherointj superherointj mentioned this pull request Apr 21, 2024
Merged
@superherointj superherointj merged commit cb4064c into release-23.11 Apr 21, 2024
17 checks passed
@emilylange emilylange deleted the vce_nixfmt_rfc branch May 14, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superherointj superherointj superherointj approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vscode 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebTM @superherointj