Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fractal: 6 -> 7 #308809

Merged
merged 1 commit into from
May 5, 2024
Merged

fractal: 6 -> 7 #308809

merged 1 commit into from
May 5, 2024

Conversation

networkException
Copy link
Member

Description of changes

This pull request updates fractal from version 6 to 7.

Release notes: https://gitlab.gnome.org/World/fractal/-/releases/7

Note that this is a draft based on #291339, once that's merged I'll rebase this pull request on top of master.

Also note that, as documented in the commit, using rev = "7"; didn't work anymore and would resolve to the bogus refs/environments/review-jsparber-h-cxnwl8/deployments/2.

Additionally, the hash of the src FDO is not compatible with falling back to fetchgit as fetchgit does not respect export-ignore git attributes and GitLab's repository archive endpoint does.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@networkException
Copy link
Member Author

Oops, sorry for the pings. Perhaps I should've just used master as a base and ignore eval failing 😅

@AndersonTorres
Copy link
Member

Please close this and open other PR, or else you will ping the planet again.

@emilylange
Copy link
Member

Please close this and open other PR, or else you will ping the planet again.

No, @AndersonTorres.

This is a draft PR. It has been opened as a draft from the getgo.
Due to this, no codeowner has been pinged yet.

Hover over the moon icon next in the reviewer list and note that it reads

[...] will be requested when the pull request is marked ready for review

And even if those 6 codeowner had been pinged, those would certainly not be "the planet".

@AndersonTorres
Copy link
Member

Phew! Not so bad as I was expecting.

@ofborg ofborg bot requested a review from dasj19 May 3, 2024 17:39
@schuelermine
Copy link
Contributor

I am experiencing random short freezes on my end.

@networkException
Copy link
Member Author

interesting, anything in the logs? For me it was smooth, just some draw invalidation artifacts

@schuelermine
Copy link
Contributor

Hm, it has subsided on second launch

@schuelermine
Copy link
Contributor

(there was nothing in the logs)

schuelermine
schuelermine approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@schuelermine schuelermine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work

@schuelermine
Copy link
Contributor

I’m currently using this Fractal as my Matrix client and I haven’t noticed any issues so far

@Luflosi
Copy link
Contributor

Luflosi commented May 4, 2024

#291339 was merged.

@networkException
fractal: 6 -> 7
27626f8 
this patch updates fractal to version 7.

this also fixes nix-prefetch-git resolving `rev = "7";` to
`refs/environments/review-jsparber-h-cxnwl8/deployments/2` by using
`rev = "refs/tags/7";` directly.
@networkException networkException marked this pull request as ready for review May 4, 2024 15:11
@ofborg ofborg bot requested a review from schuelermine May 4, 2024 15:37
schuelermine
schuelermine approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@schuelermine schuelermine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build did not change so my review does not change.

yayayayaka
yayayayaka approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-linux. Device verification and sending/receiving encrypted messages work.

@yayayayaka yayayayaka merged commit 474750b into NixOS:master May 5, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schuelermine schuelermine schuelermine approved these changes

@yayayayaka yayayayaka yayayayaka approved these changes

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@dtzWill dtzWill Awaiting requested review from dtzWill

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

@dasj19 dasj19 Awaiting requested review from dasj19

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@networkException @AndersonTorres @emilylange @schuelermine @Luflosi @yayayayaka @alyssais @wegank