-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
davinci-resolve: propagate desktop file & set mainProgram
for studio version
#309514
Conversation
7f13817
to
f26c60b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please drop the first commit, we don't use nixpkgs-fmt in nixpkgs.
Also, isn't there some overlap with #278164? (Though maybe that doesn't matter since there's not much activity on the other PR)
Yeah, it's basically the same thing, but the other PR seems abandoned :( Will drop the fmt commit |
afe2c9c
to
d33c0ef
Compare
d33c0ef
to
dc7c763
Compare
dc7c763
to
1f2178f
Compare
#278164 has been merged |
yep, looks good! |
Description of changes
.desktop
file and icons for both regular and studio variants (studio variant has its icon renamed to avoid clashing with the regular variant)mainProgram
to be equal todavinci.pname
whichbuildFHSEnv
uses as the basis for the executable namefixes #278133
Closes #278164
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.