-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: 1.4.0 -> 1.4.1 #316178
meson: 1.4.0 -> 1.4.1 #316178
Conversation
@ofborg build meson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Needs some Darwin and some BSD to test.
cc @rhelmot @NixOS/darwin-maintainers |
Sorry @JohnRTitor, I don't have enough storage on my computer to build this... |
Currently building |
Because the Darwin stdenv bootstrap requires Meson (for libiconv and system_cmds), if it gets to the point where ofborg times out building LLVM, then it was able to successfully build Meson on Darwin. Looking at the logs, it appears that was the case here. |
meson 1.4.1 and llvm 16 build just fine on aarch64-darwin |
Fails to build
Cause:
|
Fixed on -next. |
I think we have sufficient confidence that this is fine on macOS and we don’t need to block further on that. |
Quick question: why would |
The former would correspond to |
Yup, |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin staging-24.05
git worktree add -d .worktree/backport-316178-to-staging-24.05 origin/staging-24.05
cd .worktree/backport-316178-to-staging-24.05
git switch --create backport-316178-to-staging-24.05
git cherry-pick -x 9d76da314b9262ae22086f859f4a815e7b33a54d |
Backport: #326178 |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.