-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tuxedo-drivers: 3.2.14 -> 4.5.0 #316708
tuxedo-drivers: 3.2.14 -> 4.5.0 #316708
Conversation
I tested it on my Tuxedo Pulse Gen1 with the 6.6 Linux Kernel, but i would appreciate feedback for newer Tuxedo Models. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me.
Will test this when I am near my tuxedo device.
homepage = "https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers"; | ||
license = lib.licenses.gpl3Plus; | ||
longDescription = '' | ||
This driver provides support for Fn keys, brightness/color/mode for most TUXEDO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Is this description still accurate?
The features list seems to suggest no.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the Hardware I/O driver for TUXEDO Control Center
is missing, but the mentioned TUXEDO Control Center isn't even packaged here, and is used by tuxedo_rs instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I would suggest to add "Hardware IO driver" without "for Tuxedo Control Center"
b1fd44c
to
b8ef83f
Compare
|
||
meta = { | ||
broken = stdenv.isAarch64 || (lib.versionOlder kernel.version "5.5"); | ||
description = "Keyboard and hardware I/O driver for TUXEDO Computers laptops"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Keyboard and hardware I/O driver for TUXEDO Computers laptops"; | |
description = "Drivers for several platform devices for TUXEDO notebooks meant for the DKMS"; |
homepage = "https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers"; | ||
license = lib.licenses.gpl3Plus; | ||
longDescription = '' | ||
This driver provides support for Fn keys, brightness/color/mode for most TUXEDO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I would suggest to add "Hardware IO driver" without "for Tuxedo Control Center"
Nice work! There is also this open pull request that intends to replace tuxedo-keyboard with tuxedo-drivers: #293017. I guess you can compare your implementation with theirs? Either way, once this has been merged, would it make sense to enable the package by default in nixos-hardware? |
I can confirm that this works on my Aura Gen1, using |
|
||
mkdir -p "$out/lib/modules/${kernel.modDirVersion}" | ||
|
||
for module in clevo_acpi.ko clevo_wmi.ko \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#293017 uses INSTALL_MOD_PATH here, which I find nice
I cherry-picked this onto nixos-24.05 and successfully used it for the past ~4 weeks with tuxedo-rs on a Pulse 14 Gen 4. |
Can this be merged? Currently can't use tuxedo-keyboard on linux > 6.9 due to this #329383 (the patch from the issue should probably be added too). |
Description of changes
This updates the tuxedo-keyboard package to 4.5.0, and renames the package to its new upstream name.
While updating the nixos module, I also removed parts of the option description that were already removed in the 3.2.0 release.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.