Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qdiskinfo: init at 0.2 #325304

Closed
wants to merge 1 commit into from
Closed

qdiskinfo: init at 0.2 #325304

wants to merge 1 commit into from

Conversation

RoyDubnium
Copy link
Contributor

@RoyDubnium RoyDubnium commented Jul 7, 2024

Description of changes

A native linux alternative to CrystalDiskInfo. Provides SMART information about ATA and NVMe drives.
https://github.com/edisionnano/QDiskInfo

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/qd/qdiskinfo/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qd/qdiskinfo/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qd/qdiskinfo/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qd/qdiskinfo/package.nix Outdated Show resolved Hide resolved
@Sigmanificient
Copy link
Member

I think you applied the wrong formatter, did you used nixfmt-rfc-style?

@RoyDubnium
Copy link
Contributor Author

Should I now squash commits?

@Sigmanificient
Copy link
Member

yes

@RoyDubnium
Copy link
Contributor Author

oops

@RoyDubnium RoyDubnium restored the master branch August 13, 2024 13:12
@RoyDubnium RoyDubnium deleted the master branch August 13, 2024 13:12
@RoyDubnium RoyDubnium mentioned this pull request Aug 13, 2024
13 tasks
@RoyDubnium
Copy link
Contributor Author

Resubmitted at #334388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants