Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 24.05] openbsd: Add static linking support #326127

Merged

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jul 10, 2024

Description of changes

Backport of #323608

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

I've had better luck creating statically-linked binaries that work than
dynamically-linked ones, so this is needed quite practically.

(cherry picked from commit 676df1c)
@Aleksanaa
Copy link
Member

wrong pr number?

@Ericson2314
Copy link
Member Author

Oops! Fixed now. Thanks.

@Ericson2314 Ericson2314 merged commit 2765920 into NixOS:release-24.05 Jul 10, 2024
22 checks passed
@Ericson2314 Ericson2314 deleted the openbsd-static-24.05 branch July 10, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants