Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] meson: 1.4.0 -> 1.4.1 #326178

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

alyssais
Copy link
Member

Description of changes

(cherry picked from commit 9d76da3)

This is a bug fix release, and we haven't seen any problems with it to my knowledge, so I think it makes sense to backport it. It's a manual backport because the original commit removed a patch that never existed in 24.05.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

(cherry picked from commit 9d76da3)
@alyssais alyssais mentioned this pull request Jul 10, 2024
13 tasks
@AndersonTorres
Copy link
Member

The cherry-picks check can be ignored?

@alyssais
Copy link
Member Author

Note this should not necessarily be treated as a hard fail, but a reviewer's attention should be drawn to it and github actions have no way of doing that but to raise a 'failure'

and as I explained, this has to be a manual backport due to a patch not being applied on staging.

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, built on aarch64-darwin community builder

@JohnRTitor JohnRTitor merged commit 5af04b0 into NixOS:staging-24.05 Jul 11, 2024
29 of 32 checks passed
@alyssais alyssais deleted the 24.05-meson-1.4.1 branch July 11, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants