python312Packages.inflect: add missing dependency + cleaning #330114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should commit message use |
Co-authored-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
Sure ! Done :) |
|
This PR is an attempt at splitting #329464 to target |
|
Result of 4 packages marked as broken and skipped:
5 packages failed to build:
210 packages built:
|
|
Result of 25 packages marked as broken and skipped:
26 packages failed to build:
67 packages built:
|
|
Result of 25 packages marked as broken and skipped:
26 packages failed to build:
67 packages built:
|
GaetanLepage
changed the title
|
@ofborg build python3Packages.inflect python311Packages.inflect |
13 tasks
|
Result of 4 packages marked as broken and skipped:
6 packages failed to build:
228 packages built:
|
13 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@dotlambda Thank you for your very constructive and nice comment towards someone who's maintaining the python stack since weeks... And we all know it's a lot of work. With such comment you insult not only the contributor but also @natsukium who advised to explicitly require it in #329849 (comment) Please make sure to avoid such kind of comment in the future and show a bit of respect. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.