Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maude: 3.3.1 -> 3.4 #331988

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

timKraeuter
Copy link

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old url now jumps to this new one. LGTM.

@donovanglover
Copy link
Member

Result of nixpkgs-review pr 331988 run on x86_64-linux 1

1 package failed to build:
  • tamarin-prover
1 package built:
  • maude

Seems to be caused by https://github.com/tamarin-prover/tamarin-prover/blob/7b79a738b75c6fc8825614c23e3dc43381d3a203/src/Main/Console.hs#L176

@timKraeuter
Copy link
Author

Result of nixpkgs-review pr 331988 run on x86_64-linux 1
1 package failed to build:
1 package built:

Seems to be caused by https://github.com/tamarin-prover/tamarin-prover/blob/7b79a738b75c6fc8825614c23e3dc43381d3a203/src/Main/Console.hs#L176

Thanks for the information. I created a pull request to update Maude in the tamarin-prover.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are broken.

@timKraeuter
Copy link
Author

Once my pull request to tamarin-prover is merged and the package is updated, it should work.

@drupol
Copy link
Contributor

drupol commented Aug 4, 2024

Mark it as draft then please, so we don't spend time on this yet.

@timKraeuter timKraeuter marked this pull request as draft August 4, 2024 21:19
@timKraeuter
Copy link
Author

My pull request to tamarin-prover was merged. They aim for a release in mid-September, which would include my fix.
I will wait with this pull request until a new release of the prover, which then becomes compatible with the new Maude version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants