nixos/flatpak: add package option #331993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this patch adds the `services.flatpak.package` option to allow overriding the package added by this module to `environment.systemPackages` and the likes. This is useful in scenarios where applications call the flatpak binary to query information like writable directories and there is a custom package returning different results from the vanilla binary. See https://github.com/crabdancing/nixpak-flatpak-wrapper
networkException
added a commit
to networkException/nixpak-flatpak-wrapper
that referenced
this pull request
Aug 3, 2024
Instead of adding the wrapper package to `environment.systemPackages` and the likes ourselves, we now use the `services.flatpak.package` option. See NixOS/nixpkgs#331993
Aleksanaa
approved these changes
Aug 3, 2024
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This pull request adds the
services.flatpak.packageoption to allow overriding the package added by this module toenvironment.systemPackagesand the likes.This is useful in scenarios where applications call the flatpak binary to query information like writable directories and there is a custom package returning different results from the vanilla binary.
See https://github.com/crabdancing/nixpak-flatpak-wrapper
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.