[Backport staging-24.05] stdenv: make sure the env-vars file created is not world readable
#332347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Under some circumstances this file might contain private information that should not be accessible to everybody. (cherry picked from commit c47a1e7)
github-actions
bot
added
the
1.severity: security
13 tasks
ofborg
bot
added
10.rebuild-darwin-stdenv
|
Converting to draft, it causes an issue on Darwin, see #335016 |
This fixes the regression introduced by c47a1e7 on Darwin. The creation of the file using `install` and process substitution does not work on Darwin, you get the following complain: ``` install: skipping file '/dev/fd/63', as it was replaced while being copied ``` Fixes #335016 (cherry picked from commit d00775c)
|
Backported ##335593 for the Darwin issue, this should be good to go. |
smancill
approved these changes
Aug 29, 2024
|
Merging since this is the same change as approved #335593 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
staging-24.05, triggered by a label in #331576.Also backported #335593