-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zfs_2_2: 2.2.4 -> 2.2.5 #332848
zfs_2_2: 2.2.4 -> 2.2.5 #332848
Conversation
Patches all appear to be merged into this release.
Some of the failed builds seem concerning? Or are they already broken? |
Closes unreviewed #331980 |
|
||
isUnstable = true; | ||
tests = [ | ||
nixosTests.zfs.unstable | ||
]; | ||
|
||
# 6.10 patches approved+merged to the default branch, not in staging yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked & these patches do appear in the changelog as merged 👍
Yea I believe I had a system resource problem. I had rerun a few of the failures and they succeeded, but now just did nixpkgs-review again after a reboot and much improved. Result of 8 packages marked as broken and skipped:
102 packages built:
|
Maintainers decided to not backport NixOS#332848, so no 6.10 compatibility for ZFS 2.2 on 24.05.
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-332848-to-release-24.05 origin/release-24.05
cd .worktree/backport-332848-to-release-24.05
git switch --create backport-332848-to-release-24.05
git cherry-pick -x 8d0db928289e0d3fd8fbefad0a15b3e6c734fb2e fde7c3afb37e7a9d4be39e112b4b8f0bd6f75352 |
Description of changes
Update zfs_unstable to match as well.
Things done
Result of
nixpkgs-review
run on x86_64-linux 18 packages marked as broken and skipped:
15 packages failed to build:
87 packages built:
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.