zfs_2_2: 2.2.4 -> 2.2.5 #332848
Merged
zfs_2_2: 2.2.4 -> 2.2.5 #332848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patches all appear to be merged into this release.
|
Some of the failed builds seem concerning? Or are they already broken? |
|
Closes unreviewed #331980 |
toastal
reviewed
Aug 7, 2024
|
|
||
| isUnstable = true; | ||
| tests = [ | ||
| nixosTests.zfs.unstable | ||
| ]; | ||
|
|
||
| # 6.10 patches approved+merged to the default branch, not in staging yet |
There was a problem hiding this comment.
I checked & these patches do appear in the changelog as merged 👍
|
Yea I believe I had a system resource problem. I had rerun a few of the failures and they succeeded, but now just did nixpkgs-review again after a reboot and much improved. Result of 8 packages marked as broken and skipped:
102 packages built:
|
adamcstephens
approved these changes
Aug 7, 2024
13 tasks
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Aug 14, 2024
Maintainers decided to not backport NixOS#332848, so no 6.10 compatibility for ZFS 2.2 on 24.05.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-332848-to-release-24.05 origin/release-24.05
cd .worktree/backport-332848-to-release-24.05
git switch --create backport-332848-to-release-24.05
git cherry-pick -x 8d0db928289e0d3fd8fbefad0a15b3e6c734fb2e fde7c3afb37e7a9d4be39e112b4b8f0bd6f75352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update zfs_unstable to match as well.
Things done
Result of
nixpkgs-reviewrun on x86_64-linux 18 packages marked as broken and skipped:
15 packages failed to build:
87 packages built:
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.