electron_31: init at 31.4.0, electron: bump default version to v31, electron-chromedriver_31: 31.3.0 -> 31.4.0 #333907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teutat3s
changed the title
teutat3s
force-pushed
the
electron-31
branch
2 times, most recently
from
272b544
to
ef0c983
Compare
|
Result of 4 packages failed to build:
52 packages built:
|
1 task
|
Sick, I need electron 31 for a project i'm working on and the broken update.py was tripping me up. I got as far as updating the depot_tools to read the new DEPS format but didn't have enough time to get the new builtin condition variables working. |
Can you pin this program to electron 30 to fix the build? Would that also fix the other build failures? |
|
These builds are already failing on latest
|
|
I'll fix the bitwarden directory connector then. The gyp in there wants to use distutils. |
|
Looks like redisinsight has a similar gyp error. |
Co-authored-by: Yureka <yuka@yuka.dev>
- Changelog: https://github.com/electron/electron/releases/tag/v31.0.0 - Diff: electron/electron@refs/tags/v31.0.0...v31.4.0 Co-authored-by: Yureka <yuka@yuka.dev>
- Changelog: https://github.com/electron/electron/releases/tag/v31.0.0 - Diff: electron/electron@refs/tags/v31.0.0...v31.4.0 Co-authored-by: Yureka <yuka@yuka.dev>
Co-authored-by: Yureka <yuka@yuka.dev>
Co-authored-by: Yureka <yuka@yuka.dev>
Last contributions were in 2018 and 2015. Update list to de-facto maintainers.
Upstream switched to electron 31 in version 1.11.70 element-hq/element-desktop@597f356
teutat3s
changed the title
|
Result of 4 packages failed to build:
54 packages built:
|
13 tasks
22 tasks
fixed by #335874
fixed by #335883 |
|
Result of 3 packages failed to build:
55 packages built:
|
This was referenced Aug 20, 2024
13 tasks
onny
pushed a commit
that referenced
this pull request
Aug 23, 2024
As originally mentioned in #331868, feishin now [1] depends on Electron v31, which was not packaged at the time (#325428). It has since been fixed (by #333907). [1]: https://github.com/jeffvli/feishin/blob/f2beeef/package.json#L234
greg-hellings
pushed a commit
to greg-hellings/nixpkgs
that referenced
this pull request
Aug 24, 2024
As originally mentioned in NixOS#331868, feishin now [1] depends on Electron v31, which was not packaged at the time (NixOS#325428). It has since been fixed (by NixOS#333907). [1]: https://github.com/jeffvli/feishin/blob/f2beeef/package.json#L234
emilazy
pushed a commit
to emilazy/nixpkgs
that referenced
this pull request
Aug 28, 2024
As originally mentioned in NixOS#331868, feishin now [1] depends on Electron v31, which was not packaged at the time (NixOS#325428). It has since been fixed (by NixOS#333907). [1]: https://github.com/jeffvli/feishin/blob/f2beeef/package.json#L234 (cherry picked from commit 3d15951)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Huge thanks to @yu-re-ka for providing these patches.
Also switches the default electron version to 31. The plan is to backport only the new version without touching the default for NixOS 24.05.
Fixes #325428.
Pinging @travisbhartwell @manveru for maintainer update.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.