-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron_31: init at 31.4.0, electron: bump default version to v31, electron-chromedriver_31: 31.3.0 -> 31.4.0 #333907
Conversation
272b544
to
ef0c983
Compare
Result of 4 packages failed to build:
52 packages built:
|
Sick, I need electron 31 for a project i'm working on and the broken update.py was tripping me up. I got as far as updating the depot_tools to read the new DEPS format but didn't have enough time to get the new builtin condition variables working. |
Can you pin this program to electron 30 to fix the build? Would that also fix the other build failures? |
These builds are already failing on latest
|
I'll fix the bitwarden directory connector then. The gyp in there wants to use distutils. |
Looks like redisinsight has a similar gyp error. |
Co-authored-by: Yureka <yuka@yuka.dev>
- Changelog: https://github.com/electron/electron/releases/tag/v31.0.0 - Diff: electron/electron@refs/tags/v31.0.0...v31.4.0 Co-authored-by: Yureka <yuka@yuka.dev>
- Changelog: https://github.com/electron/electron/releases/tag/v31.0.0 - Diff: electron/electron@refs/tags/v31.0.0...v31.4.0 Co-authored-by: Yureka <yuka@yuka.dev>
Co-authored-by: Yureka <yuka@yuka.dev>
Co-authored-by: Yureka <yuka@yuka.dev>
Last contributions were in 2018 and 2015. Update list to de-facto maintainers.
Upstream switched to electron 31 in version 1.11.70 element-hq/element-desktop@597f356
Result of 4 packages failed to build:
54 packages built:
|
fixed by #335874
fixed by #335883 |
Result of 3 packages failed to build:
55 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
As originally mentioned in #331868, feishin now [1] depends on Electron v31, which was not packaged at the time (#325428). It has since been fixed (by #333907). [1]: https://github.com/jeffvli/feishin/blob/f2beeef/package.json#L234
As originally mentioned in NixOS#331868, feishin now [1] depends on Electron v31, which was not packaged at the time (NixOS#325428). It has since been fixed (by NixOS#333907). [1]: https://github.com/jeffvli/feishin/blob/f2beeef/package.json#L234
As originally mentioned in NixOS#331868, feishin now [1] depends on Electron v31, which was not packaged at the time (NixOS#325428). It has since been fixed (by NixOS#333907). [1]: https://github.com/jeffvli/feishin/blob/f2beeef/package.json#L234 (cherry picked from commit 3d15951)
Description of changes
Huge thanks to @yu-re-ka for providing these patches.
Also switches the default electron version to 31. The plan is to backport only the new version without touching the default for NixOS 24.05.
Fixes #325428.
Pinging @travisbhartwell @manveru for maintainer update.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.