Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webcord-vencord: electron_29 -> electron_30 #335876

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

NotAShelf
Copy link
Member

@NotAShelf NotAShelf commented Aug 19, 2024

Description of changes

Changes webcord-vencord's electron version to electron 30 as electron 29 is
almost EoL. Should address #335850.

Tested on x86_64, app starts as intended and Vencord works as expected. No
crashes/undesirable behaviour observed. Further testing appreciated.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See
    Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using
    nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all
    changes have to be committed, also see
    nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in
    ./result/bin/)
  • 24.11 Release Notes
    (or backporting
    23.11
    and
    24.05
    Release notes)
    • (Package updates) Added a release notes entry if the change is major or
      breaking
    • (Module updates) Added a release notes entry if the change is
      significant
    • (Module addition) Added a release notes entry if adding a new NixOS
      module
  • Fits
    CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64, app starts as intended and Vencord works as expected. No
crashes/undesirable behaviour observed.

Can confirm, looking good for me.

@SuperSandro2000 SuperSandro2000 merged commit 1bc1437 into NixOS:master Aug 20, 2024
30 of 32 checks passed
@emilazy emilazy added the backport release-24.05 Backport PR automatically label Aug 25, 2024
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants