Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: add nix-team to CODEOWNERS #336270

Merged
merged 1 commit into from
Aug 22, 2024
Merged

nix: add nix-team to CODEOWNERS #336270

merged 1 commit into from
Aug 22, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 21, 2024

Description of changes

Depends on NixOS/org#24

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@Mic92 Mic92 marked this pull request as draft August 21, 2024 06:21
@Mic92 Mic92 marked this pull request as ready for review August 21, 2024 19:41
@Mic92
Copy link
Member Author

Mic92 commented Aug 21, 2024

cc @roberth

Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the suggestion, but 👍

.github/CODEOWNERS Outdated Show resolved Hide resolved
Update .github/CODEOWNERS

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
@edolstra edolstra merged commit a8dc85a into NixOS:master Aug 22, 2024
8 of 9 checks passed
@Mic92 Mic92 deleted the nix-owner branch August 22, 2024 17:35
@Mic92
Copy link
Member Author

Mic92 commented Aug 23, 2024

Backport #336734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants