[backport 24.05] treewide: Rename android sdkVer and ndkVer #336577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdkVer
conflicts with the oldsdkVer
(nowdarwinSdkVersion
but that still usessdkVer
if set) used by darwinThis shouldn't be an issue but due to
pkgs/development/interpreters/python/cpython/default.nix
running
lib.filterAttrs (n: v: ! lib.isDerivation v && n != "passthruFun")
on it's inputs (2 of them are darwin only)the
throw "Unsupported sdk...
inpkgs/top-level/darwin-packages.nix
will be triggered.After this change
pkgsCross.armv7a-android-prebuilt.python3.pythonOnBuildForHost
won't fail witherror: Unsupported sdk: 33
Issue was bisected to 3cb23ce
(cherry picked from commit 1144d46)## Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.